Flecs identifiers #536
Open
Flecs identifiers #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of identifiers and types
…v into flecs_identifiers
|
@Srekel Could you help review this? |
|
@robinheydon which verison of Zig are you using/targeting? |
hazeycode
requested changes
Mar 29, 2024
hazeycode
requested changes
Mar 29, 2024
| @@ -13,6 +13,7 @@ pub fn build(b: *std.Build) void { | |||
| .target = target, | |||
| .optimize = optimize, | |||
| }); | |||
| b.installArtifact(flecs); | |||
There was a problem hiding this comment.
I'm not sure what's going on with the diff, but installArtifact(flecs) is already being called on main branch, albeit not on this exact line. Can you try rebasing this branch?
Comment on lines
+27
to
+33
| const ztracy = b.addModule("root", .{ | ||
| .root_source_file = .{ .path = "src/ztracy.zig" }, | ||
| .imports = &.{ | ||
| .{ .name = "ztracy_options", .module = options_module }, | ||
| }, | ||
| }); | ||
| ztracy.addIncludePath(.{ .path = "libs/tracy/tracy" }); |
There was a problem hiding this comment.
Likewise here (changes present on main not showing in diff)
There was a problem hiding this comment.
strange... I'll have a look
Yeah I'll take a look after your initial concerns have been addressed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of flecs identifiers into zig-gamedev. This is done either by just adding the external symbol definition or by using
ecs_id(which uses@externto reference the symbol created by the C macro used to create the symbol).This also changes the interface for flecs.init to take an allocator, and then use that allocator within flecs. This allows the use of tracy allocator or a logging allocator to watch what flecs is doing with memory.
Added
componentWithOptionsfor defining a component with additional options, such as an explicit name / symbol rather than just relying on@typeName. Also addedtagWithOptionsfor defining a tag with additional options.Also added
setMonitorinto the zglfw Window struct.Also fixed ztracy allocator to the latest zig allocator interface.