Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in worker example, so that the last second of audio would be fully encoded #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix bug in worker example, so that the last second of audio would be fully encoded #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions worker-example/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,16 @@
mp3Encoder = new lamejs.Mp3Encoder(wav.channels, wav.sampleRate, config.bitRate || 96);

var remaining = samplesLeft.length;
for (var i = 0; remaining >= maxSamples; i += maxSamples) {
var left = samplesLeft.subarray(i, i + maxSamples);
for (var i = 0; remaining > 0; i += maxSamples) {
const chunkSize = Math.min(maxSamples, remaining);
var left = samplesLeft.subarray(i, i + chunkSize);
var right;
if (samplesRight) {
right = samplesRight.subarray(i, i + maxSamples);
right = samplesRight.subarray(i, chunkSize);
}
var mp3buf = mp3Encoder.encodeBuffer(left, right);
appendToBuffer(mp3buf);
remaining -= maxSamples;
remaining -= chunkSize;
self.postMessage({
cmd: 'progress',
progress: (1 - remaining / samplesLeft.length)
Expand Down