Early out in load_buffer for empty inputs to avoid allocations #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling
xml_document::load_string
on an empty buffer resulted in a single byte allocation for the buffer copy; this allocation was redundant as no data was parsed, so we now add the same early-out that already exists inxml_parser::parse
toload_buffer_impl
.This should almost never matter but might help applications that for some strange reason frequently parse empty documents without a higher level size check on the app side.