Poller tests fix #960
Closed
Poller tests fix #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
All tests run locally, not sure what the problem is |
Contributor
|
I encountered the same problem, is this fix ready ? |
|
Encountered same issue as well. Would love this fix. |
drewnoakes
reviewed
Jun 13, 2025
drewnoakes
reviewed
Jun 13, 2025
Fixes nullability warning
drewnoakes
reviewed
Jun 13, 2025
| /// Get the number of bytes within the buffer that is past the Offset (ie, buffer-length minus offset). | ||
| /// </summary> | ||
| public int Size => m_innerBuffer.Length - Offset; | ||
| public int Size => m_innerBuffer == null ? 0 : m_innerBuffer.Length - Offset; |
Member
There was a problem hiding this comment.
I'm not sure about this change. Code shouldn't be using an initialised version of this struct. The buffer should always be non-null. If it's null here, then there's a bug somewhere else. That is the bug that should probably be identified and fixed. At least that's my working assumption.
Member
|
Going to close this out as the primary change that was made here was made elsewhere (and so disappeared from this diff). The only remaining change is the null defense, and I don't think we should be making that, as commented above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #959 for running unit tests in Debug.