Skip to content

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented Jun 2, 2025

Pull Request Notice

Before sending a pull request make sure each commit solves one clear, minimal,
plausible problem. Further each commit should have the following format:

Problem: X is broken

Solution: do Y and Z to fix X

Is this really a strict requirement? Some of the commits are basically common CMake standards with no clear defined problem. Would make sense maybe when squashing the PR and writing an appropriate message in the PR description to be used.

Problem: Project does not build with CMake 4.0 and many patterns are outdated

Solution: Bump the CMake policies to use the latest policies up to 4.0 and use more modern CMake patterns in some places

@LecrisUT LecrisUT force-pushed the cmake/maintenance branch from c190386 to bf40bcf Compare June 2, 2025 16:38
LecrisUT added 2 commits June 2, 2025 18:46
Normally this should not be provided since most builds in CMake land are out-of-source and if provided it should be by CMake to account for specific generator files
@LecrisUT LecrisUT force-pushed the cmake/maintenance branch 2 times, most recently from 809cc79 to d679dae Compare June 2, 2025 16:48
@LecrisUT
Copy link
Author

LecrisUT commented Jun 2, 2025

Since the CI is broken (beyond what bumping the builder to ubuntu-latest), here are the builds running on Fedora rawhide (linked inside are the builds running for CMake 4.0)

@bluca
Copy link
Member

bluca commented Jun 2, 2025

As the header in these files mention, these files are generated, so these changes have to happen in https://github.com/zeromq/zproject or they'll be overwritten on the next regeneration

@LecrisUT
Copy link
Author

LecrisUT commented Jun 2, 2025

Transferred over at zeromq/zproject#1345. I couldn't follow the generation instructions there, so I am asking for help on that front, or I would do that generation manually as well.

@sphaero
Copy link
Contributor

sphaero commented Jun 5, 2025

Since it is in zproject now are you able to regenerate and send a new PR for this?

@LecrisUT
Copy link
Author

LecrisUT commented Jun 5, 2025

Since it is in zproject now are you able to regenerate and send a new PR for this?

I'm afraid that's beyond my understanding of the project, could someone else take over that?

@sphaero
Copy link
Contributor

sphaero commented Jun 6, 2025

It's quite simple. If you have zproject installed just run gsl project.xml in the repo root and commit the changes.

#2311

@sphaero
Copy link
Contributor

sphaero commented Jun 6, 2025

closing this one

@sphaero sphaero closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants