tests: add and follow most of eslint rules #237
Conversation
| // Code style | ||
| "indent": [2, 2], | ||
| "quotes": [2, "single"], | ||
| "semi": ["error", "always"], |
There was a problem hiding this comment.
Once again, I strongly disagree with adding rules that do not add value to our development process... using or not semicolons is one of those, I will feel like I'm wasting my time if the CI fails because I didn't add a semicolon, OTOH I would really love the CI to tell me that I forgot a debugger line for example
There was a problem hiding this comment.
@facuspagnuolo the discussion about this is here: OpenZeppelin/configs#1
I might have misunderstood your opinion there, sorry about that. Feel free to reopen it and we'll keep talking there.
Later, if we agree to not use the semicolons, I'll adjust the code. This one is super simple, because eslint can autoapply it.
| "comma-dangle": [1, "always-multiline"], | ||
| "no-dupe-args": 2, | ||
| "no-dupe-keys": 2, | ||
| "no-debugger": 0, |
There was a problem hiding this comment.
this are the kind of rules that I find useful
There was a problem hiding this comment.
For all the ones that you don't find useful and want to remove, please open an issue on the code-style repo. The idea is to progress step-by-step until we are all comfortable with the rules, hopefully without hating each other when we disagree :)
Brought to you with 🤓 by the #static task force.
Remember that if you have $opinions, you should report an issue on https://github.com/ZeppelinSolutions/code-style where we will discuss about it and then update the rules accordingly, if required.