-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2321 - Fix private callback visibility #2325
Draft
Jeckerson
wants to merge
14
commits into
development
Choose a base branch
from
#2321-private-callback-visibility
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeckerson
changed the title
#2321 - Fox private callback visibility
#2321 - Fшx private callback visibility
Nov 12, 2021
Jeckerson
changed the title
#2321 - Fшx private callback visibility
#2321 - Fix private callback visibility
Nov 12, 2021
Codecov Report
@@ Coverage Diff @@
## development #2325 +/- ##
================================================
- Coverage 7.18% 7.13% -0.05%
+ Complexity 8639 8612 -27
================================================
Files 343 344 +1
Lines 21977 21939 -38
================================================
- Hits 1578 1566 -12
+ Misses 20399 20373 -26 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
# Conflicts: # Library/CompilerFile.php # composer.lock # config/autoload.php # phpunit.xml.dist # tests/ext-bootstrap.php # zephir
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Thanks