-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename model version to a model #13
Conversation
WalkthroughThe project has undergone a refactoring to update the handling of model artifacts, including changes in file paths like Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- template/configs/inference.yaml
- template/configs/training_rf.yaml
- template/configs/training_sgd.yaml
Files selected for processing (5)
- .gitignore (1 hunks)
- template/pipelines/inference.py (1 hunks)
- template/quickstart.ipynb (8 hunks)
- template/run.py (1 hunks)
- template/steps/model_promoter.py (1 hunks)
Additional comments: 8
template/pipelines/inference.py (1)
- 28-31: The updates to use
get_pipeline_context().model.get_artifact
align with the PR objectives and reflect the shift from "model version" to "model" in the ZenML framework. Ensure that all references to the old method have been updated accordingly..gitignore (1)
- 136-136: The addition of
.local
to the.gitignore
file is a standard practice to prevent local configuration files from being tracked in version control.template/steps/model_promoter.py (1)
- 39-60: The updates to use
get_step_context().model
andcurrent_model.set_stage(stage, force=True)
align with the PR objectives and reflect the shift from "model version" to "model" in the ZenML framework. Ensure that all references to the old method have been updated accordingly.template/run.py (1)
- 204-204: The updates to the
config
dictionary keys from "model_version" to "model" are consistent with the PR objectives and reflect the shift from "model version" to "model" in the ZenML framework. Ensure that all references to the old keys have been updated accordingly.template/quickstart.ipynb (4)
145-145: The replacement of
ModelVersion
withModel
in the notebook aligns with the PR objectives and reflects the shift from "model version" to "model" in the ZenML framework. Ensure that all references to the old class have been updated accordingly.732-732: The use of the
Model
object to create a ZenML Model and associate it with pipelines is consistent with the new approach in the ZenML framework.943-946: The update to load the model using
get_step_context().model
andmodel.load_artifact("sklearn_classifier")
in theinference_predict
step is consistent with the new model handling approach in ZenML.997-997: The configuration to always load the production model by passing in the
production
stage into theModel
config is a good practice to ensure consistency in model usage across pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/ci.yml (1 hunks)
Additional comments: 1
.github/workflows/ci.yml (1)
- 58-58: The update to the default value for
ref-zenml
aligns with the PR's objectives to reflect the new branch naming conventions. Ensure that the branch'feature/OSSK-342-rename-model-version-to-a-model'
exists and is the correct reference for this workflow.
Companion for zenml-io/zenml#2267
Summary by CodeRabbit
New Features
Refactor
Documentation
.gitignore
to exclude local files from the repository.Bug Fixes