💄 Add global information #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of members and repositories are now displayed alongside a landing page #4
tbetous
reviewed
Apr 18, 2019
|
Nice design ! 👍 |
Thank you ! It's far from what the final product will be, I just threw it together to avoid having something empty for now. We'll need to agree on a final design eventually but until then the MVP will probably stay simple. |
Made the display nicer, added countup.js to animate our stats #4
|
Is this still work in progress @christopherkade 😄 ? |
It is since we are missing the number of PRs done by our members (#4). It would involve updating the Github Insights project first and then updating the current view. |
|
Maybe we could postpone this part ? If so could I review this PR ? |
|
Sounds good to me, of course, go ahead ! 😄 |
frinyvonnick
approved these changes
Apr 20, 2019
Switched to react-countup, updated html tags for accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Styles are a work in progress, the goal being to display the data)
Github Insights must be updated to retrieve the number of PRs made by members of the organisation in order to move forward. (See Zenika/github-insights#8)