Toggle to remove focus of the search bar at startup #2920
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
bon-sai-tree
force-pushed
the
toggle-startup-focus
branch
from
0daf3fe to
b1d750a
Compare
bon-sai-tree
force-pushed
the
toggle-startup-focus
branch
from
67a4a20 to
996f042
Compare
dosubot
bot
added
size:XS
|
Hey @mauro-balades, I've just merged the upstream changes back into the branch, so it should be ready to merge once again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser launches, the urlbar is always focused, instead of the homepage. This behavior doesn't happen on Firefox and doesn't work for users that have a homepage with a searchbar.
This PR uses a toggle to disable the focusing of the urlbar: zen.urlbar.disable-initial-focus
The default value is false so it doesn't change anything for existing users.
There was already an PR without an toggle: #1742
Also an issue: #973
And a discussion: #1169
I'm not really familiar with the codebase and would appreciate feedback :)