Fix/gh 12076 f6 float urlbar - #14697
Open
saberoueslati wants to merge 4 commits into
Open
Conversation
…ng mode Keyboard focus (e.g. F6) only set the "focused" attribute without opening the results view, so startLayoutExtend() never ran and zen-floating-urlbar was never set. Clicking/typing floated correctly because both open the view. Extend the autoOpen condition in _on_focus to also open the view when zenUrlbarBehavior is "float", reusing the existing open/close -> float/unfloat machinery.
dosubot
Bot
added
size:M
Member
|
AI |
Author
|
@mr-cheffy yes I did use AI to help me specially write comments and the PR description but took the time to read its output and specially took the time to test thoroughly the solution, evidenced by the video I made of me testing. Otherwise I also looked in the contributing guidelines, there's no mention of an anti AI or LLM policy, If I've seen that I would've not used it all. Can you please clarify the stance of this repo concerning LLM and AI so I can be compliant ?, thank you. |
mr-cheffy
requested changes
Jul 28, 2026
| * | ||
| * @param {object} options Options object | ||
| * @param {Event} options.event The event associated with the call to autoOpen. | ||
| + * @param {boolean} [options.allowFocusEvent] Whether a focus event is allowed |
Member
There was a problem hiding this comment.
No need for this comment, we try make patches small
| * @returns {boolean} Whether the view was opened. | ||
| */ | ||
| - autoOpen({ event, suppressFocusBorder = true }) { | ||
| + autoOpen({ |
Member
There was a problem hiding this comment.
No need to indent it, for the same reason
dosubot
Bot
added
size:S
saberoueslati
force-pushed
the
fix/gh-12076-f6-float-urlbar
branch
from
July 28, 2026 21:22
58ba0f0 to
8d5e9c1
Compare
dosubot
Bot
added
size:M
dosubot
Bot
added
size:S
Author
|
@mr-cheffy made the changes asked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the URL bar not floating when focused with F6 while using the Always Floating URL bar behavior.
F6 focuses the URL bar through a
focusevent, butUrlbarView.autoOpen()previously only opened the view for mouse, click, and command events. This change adds an explicit opt-in path for focus events and enables it only for Zen's floating URL bar behavior, leaving the existing behavior unchanged in other modes.A browser regression test now synthesizes F6 and verifies that the URL bar enters its floating state.
Closes #12076
Video of manual test here :
Screencast.from.2026-07-24.10-25-44.webm
Testing
Added regression coverage to
zen/tests/urlbar/browser_floating_urlbar.js.