Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-docs: Use ubuntu-latest #281

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Oct 21, 2024

Commit bd30042 removed the sudo usage
which was the actual culprit for using the wrong pip version. Bump up
to ubuntu-latest again.

@awelzel
Copy link
Contributor Author

awelzel commented Oct 21, 2024

@bbannier - see anything wrong with this? It's a follow-up to #280 based on the comment I made there. I'll update the commit to be a bit more descriptive if you think this is good.

@awelzel awelzel requested a review from bbannier October 21, 2024 11:26
@bbannier
Copy link
Member

bbannier commented Oct 21, 2024

@bbannier - see anything wrong with this? It's a follow-up to #280 based on the comment I made there. I'll update the commit to be a bit more descriptive if you think this is good.

Not really sure how this failed before when we were already using actions/setup-python and were also setting python-version; AFAICT this should never have exposed us to issues from the base image (actions/runner-images#10636), but it did. By using an unpinned image we allow GH to break us again, and I do don't think we get much benefit from defaulting to the latest image beyond not having to worry about that image being retired.

@awelzel
Copy link
Contributor Author

awelzel commented Oct 21, 2024

Not really sure how this failed before when we were already using actions/setup-python and were als setting python-version

Pretty sure that because of the sudo usage it would reset PATH and use the system pip rather than pip provided by setup-python. So I think the right fix was to remove the sudo.

Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure how this failed before when we were already using actions/setup-python and were als setting python-version

Pretty sure that because of the sudo usage it would reset PATH and use the system pip rather than pip provided by setup-python. So I think the right fix was to remove the sudo.

🤦.

Still not fully convinced of the benefit of "latest", but I guess it now might hurt less.

Do you have an idea why we need to "test" this against so many different versions? With your explanation it might not have tested much before anyway, and I also do not understand why we would care at all as long as we can build on RTD and with our minimum supported version (if at all).

Commit bd30042 removed the sudo usage
which was the actual culprit for using the wrong pip version. Bump up
to ubuntu-latest again.
@awelzel awelzel force-pushed the topic/awelzel/try-ubuntu-latest-once-more branch from cd031f5 to b9f7da4 Compare October 21, 2024 12:53
@awelzel awelzel changed the title Try ubuntu-latest once more generate-docs: Use ubuntu-latest Oct 21, 2024
@awelzel awelzel marked this pull request as ready for review October 21, 2024 12:54
@awelzel awelzel merged commit 6868beb into master Oct 21, 2024
10 checks passed
@awelzel awelzel deleted the topic/awelzel/try-ubuntu-latest-once-more branch October 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants