Document &priority=N for evt files
#277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
reviewed
Oct 15, 2024
Also reorganize to make it a little more consistent with other parts.
evantypanski
force-pushed
the
topic/etyp/document-evt-priority
branch
from
92a4610
to
4d84aed
Compare
bbannier
approved these changes
Oct 15, 2024
|
Merged with fa09ff9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined the two lines for
on HOOK_IDinto one with the two common optional parameters (if ( COND )and&priorityI'd call useful to point out). Note that the square brackets indicating optional parameters are used later forexport SPICY_ID [as ZEEK_ID];- so I think this promotes internal consistency in the docs.Also adds parens around the
COND, since blindly copying that would be invalid otherwise.Related: zeek/zeek#3974