management/full-config: no toml highlighting #228
Conversation
With Pygments 2.17, the TOML parser was rewritten[1, 2]. It now fails to parse and highlight the `full-config.ini` file. The key-only `agent-testbox` within `[instances]` makes the standard toml parsing barf, too. Flip to ini. [1] https://pygments.org/docs/changelog/#version-2-17-0 [2] pygments/pygments#2576
awelzel
force-pushed
the
topic/awelzel/no-toml-highlighting
branch
from
cf746c9
to
7ff64f3
Compare
|
Just wondering whether I am reading the Wikipedia article on the INI format correctly, INI does not usually have value-less entries, right? I am asking since if that's correct, maybe we should fix our format to e.g., make it easier to use libraries to generate such files (coming my experience of trying to read the non-standard multi-line strings in Regardless, the file definitely isn't TOML (e.g., strings are not quoted). |
|
Left a |
, but per my above comment, I think it would be great to use an INI format with less extensions (i.e., here: always require values). Could you put an issue for that onto our pile 
FWIW, our configuration files have never been completely TOML-compliant. They're TOML-ish, but not really TOML. |
|
Hey thanks for fixing this — what a headache. Per my former comment in the code I was really just looking for something that does a decent job highlighting the file. It was always simple Python convenience that wins out here. If there's any doubt here what to use, then let's simply not highlight at all.
Yeah. |
With Pygments 2.17, the TOML parser was rewritten[1, 2]. It now fails to parse and highlight the
full-config.inifile. The key-onlyagent-testboxwithin[instances]makes the standard toml parsing barf, too. Flip to ini.[1] https://pygments.org/docs/changelog/#version-2-17-0
[2] pygments/pygments#2576