Merge branch 'topic/bbannier/uninitialized-values'

zeek · Jan 8, 2025 · 789b223 · 789b223
2 parents dc31aee + 7a5f9d6
commit 789b223
Show file tree

Hide file tree

Showing 68 changed files with 105 additions and 132 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -37,7 +37,7 @@ repos:
     stages: ["pre-commit"]
 
 - repo: https://github.com/pre-commit/mirrors-clang-format
-  rev: 'v19.1.4'
+  rev: 'v19.1.6'
   hooks:
   - id: clang-format
     types_or: ["c", "c++"]
@@ -86,14 +86,14 @@ repos:
     stages: ["pre-commit"]
 
 - repo: https://github.com/crate-ci/typos
-  rev: v1.27.2
+  rev: v1.29.4
   hooks:
   - id: typos
     exclude: 'tests/.*/regexp/.*|.clang-tidy'
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.8.2
+  rev: v0.8.6
   hooks:
   - id: ruff
     args: [ --fix ]

diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,21 @@
+1.13.0-dev.43 | 2025-01-08 09:39:45 +0100
+
+  * Drop unused includes. (Benjamin Bannier, Corelight)
+
+  * Move temporaries instead of creating copies. (Benjamin Bannier, Corelight)
+
+  * Avoid copies in implementation of trivial getters. (Benjamin Bannier, Corelight)
+
+  * Avoid copy when constructing node properties. (Benjamin Bannier, Corelight)
+
+  * Bump pre-commit hooks. (Benjamin Bannier, Corelight)
+
+  * Always initialize enum member to reasonable default. (Benjamin Bannier, Corelight)
+
+  * Always initialize pointer members. (Benjamin Bannier, Corelight)
+
+  * Fix use-after-move. (Benjamin Bannier, Corelight)
+
 1.13.0-dev.34 | 2025-01-08 09:39:11 +0100
 
   * Bump `3rdparty/filesystem` to pick up fixes for clang-tidy-19. (Benjamin Bannier, Corelight)
@@ -1927,7 +1945,7 @@
 
     A chain now retains one previously used but no longer needed chunk for
     reuse, so that we can avoid constant cycles of creating/destructing
-    chunks (and their paylaod memory) in the common case of a parser
+    chunks (and their payload memory) in the common case of a parser
     consuming full chunks without yielding. The caching is also geared
     towards owning/non-owning semantics staying consistent across
     subsequent append operations.

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.13.0-dev.34
+1.13.0-dev.43
diff --git a/hilti/runtime/include/exception.h b/hilti/runtime/include/exception.h
@@ -59,10 +59,10 @@ class Exception : public std::runtime_error {
     ~Exception() override;
 
     /** Returns the message associated with the exception. */
-    auto description() const { return _description; }
+    const auto& description() const { return _description; }
 
     /** Returns the location associated with the exception. */
-    auto location() const { return _location; }
+    const auto& location() const { return _location; }
 
     /**
      * Returns a stack backtrace captured at the time the exception was

diff --git a/hilti/runtime/include/type-info.h b/hilti/runtime/include/type-info.h
@@ -137,8 +137,8 @@ class Value {
             throw InvalidValue("type info value expired");
     }
 
-    const void* _ptr;
-    const TypeInfo* _ti;
+    const void* _ptr = nullptr;
+    const TypeInfo* _ti = nullptr;
     std::weak_ptr<bool> _parent_handle;
 };
 

diff --git a/hilti/toolchain/include/ast/attribute.h b/hilti/toolchain/include/ast/attribute.h
@@ -130,7 +130,7 @@ class Attribute : public Node {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"tag", std::string{attributeName()}}};
-        return Node::properties() + p;
+        return Node::properties() + std::move(p);
     }
 
     /**

diff --git a/hilti/toolchain/include/ast/ctors/address.h b/hilti/toolchain/include/ast/ctors/address.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/rt/types/address.h>
@@ -22,7 +21,7 @@ class Address : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", to_string(_value)}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, hilti::rt::Address v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/bitfield.h b/hilti/toolchain/include/ast/ctors/bitfield.h
@@ -2,8 +2,6 @@
 
 #pragma once
 
-#include <algorithm>
-#include <memory>
 #include <utility>
 #include <vector>
 
@@ -27,11 +25,8 @@ class BitRange final : public Node {
     auto expression() const { return child<Expression>(0); }
 
     node::Properties properties() const final {
-        auto p = node::Properties{
-            {"id", _id},
-        };
-
-        return Node::properties() + p;
+        auto p = node::Properties{{"id", _id}};
+        return Node::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, const ID& id, Expression* expr, Meta meta = Meta()) {

diff --git a/hilti/toolchain/include/ast/ctors/bool.h b/hilti/toolchain/include/ast/ctors/bool.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/ast/ctor.h>
@@ -19,7 +18,7 @@ class Bool : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, bool v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/bytes.h b/hilti/toolchain/include/ast/ctors/bytes.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <string>
 #include <utility>
 
@@ -20,7 +19,7 @@ class Bytes : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, std::string value, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/error.h b/hilti/toolchain/include/ast/ctors/error.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <string>
 #include <utility>
 
@@ -20,7 +19,7 @@ class Error : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, std::string v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/integer.h b/hilti/toolchain/include/ast/ctors/integer.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/ast/ctor.h>
@@ -22,7 +21,7 @@ class IntegerBase : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}, {"width", _width}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
 protected:

diff --git a/hilti/toolchain/include/ast/ctors/interval.h b/hilti/toolchain/include/ast/ctors/interval.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/rt/types/interval.h>
@@ -21,7 +20,7 @@ class Interval : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", to_string(_value)}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, hilti::rt::Interval v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/network.h b/hilti/toolchain/include/ast/ctors/network.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/rt/types/network.h>
@@ -21,7 +20,7 @@ class Network : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", to_string(_value)}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, hilti::rt::Network v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/port.h b/hilti/toolchain/include/ast/ctors/port.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/rt/types/port.h>
@@ -21,7 +20,7 @@ class Port : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", to_string(_value)}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, hilti::rt::Port v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/real.h b/hilti/toolchain/include/ast/ctors/real.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/ast/ctor.h>
@@ -19,7 +18,7 @@ class Real : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, double v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/regexp.h b/hilti/toolchain/include/ast/ctors/regexp.h
@@ -27,7 +27,7 @@ class RegExp : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", util::join(_value, " | ")}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, std::vector<std::string> v, AttributeSet* attrs, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/stream.h b/hilti/toolchain/include/ast/ctors/stream.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <string>
 #include <utility>
 
@@ -20,7 +19,7 @@ class Stream : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, std::string value, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/string.h b/hilti/toolchain/include/ast/ctors/string.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <string>
 #include <utility>
 
@@ -21,7 +20,7 @@ class String : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", _value}, {"is_literal", _is_literal}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, std::string value, bool is_literal, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/struct.h b/hilti/toolchain/include/ast/ctors/struct.h
@@ -21,7 +21,7 @@ class Field final : public Node {
 
     node::Properties properties() const override {
         auto p = node::Properties{{"id", _id}};
-        return Node::properties() + p;
+        return Node::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, ID id, Expression* expr, Meta meta = {}) {
@@ -66,7 +66,7 @@ class Struct : public Ctor, public node::WithUniqueID {
     /** Implements the node interface. */
     node::Properties properties() const override {
         auto p = node::Properties{};
-        return Ctor::properties() + node::WithUniqueID::properties() + p;
+        return Ctor::properties() + node::WithUniqueID::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, const struct_::Fields& fields, QualifiedType* t, Meta meta = {}) {

diff --git a/hilti/toolchain/include/ast/ctors/time.h b/hilti/toolchain/include/ast/ctors/time.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <utility>
 
 #include <hilti/rt/types/time.h>
@@ -21,7 +20,7 @@ class Time : public Ctor {
 
     node::Properties properties() const final {
         auto p = node::Properties{{"value", to_string(_value)}};
-        return Ctor::properties() + p;
+        return Ctor::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, hilti::rt::Time v, const Meta& meta = {}) {

diff --git a/hilti/toolchain/include/ast/declaration.h b/hilti/toolchain/include/ast/declaration.h
@@ -119,7 +119,7 @@ class Declaration : public Node, public node::WithDocString {
                                   {"fqid", _fqid},
                                   {"canonical-id", _canonical_id}};
 
-        return Node::properties() + p;
+        return Node::properties() + std::move(p);
     }
 
     Declaration(const Declaration& other) : Node(other), node::WithDocString(other) {

diff --git a/hilti/toolchain/include/ast/declarations/imported-module.h b/hilti/toolchain/include/ast/declarations/imported-module.h
@@ -2,7 +2,6 @@
 
 #pragma once
 
-#include <memory>
 #include <string>
 #include <utility>
 #include <vector>
@@ -33,7 +32,7 @@ class ImportedModule : public Declaration {
     const auto& searchDirectories() const { return _dirs; }
     const auto& parseExtension() const { return _parse_extension; }
 
-    auto uid() const { return _uid; }
+    const auto& uid() const { return _uid; }
     void setUID(declaration::module::UID uid) { _uid = std::move(uid); }
     void clearUID() { _uid.reset(); }
     void setSearchDirectories(std::vector<hilti::rt::filesystem::path> dirs) { _dirs = std::move(dirs); }
@@ -48,7 +47,7 @@ class ImportedModule : public Declaration {
             {"dirs", util::join(_dirs)},
             {"uid", _uid ? _uid->str() : std::string("<n/a>")},
         };
-        return Declaration::properties() + p;
+        return Declaration::properties() + std::move(p);
     }
 
     static auto create(ASTContext* ctx, ID id, const std::string& parse_extension, Meta meta = {}) {
@@ -62,7 +61,9 @@ class ImportedModule : public Declaration {
     }
 
     static auto create(ASTContext* ctx, ID id, hilti::rt::filesystem::path path, Meta meta = {}) {
-        return ctx->make<ImportedModule>(ctx, std::move(id), std::move(path), path.extension(), ID{}, std::move(meta));
+        auto extension = path.extension();
+        return ctx->make<ImportedModule>(ctx, std::move(id), std::move(path), std::move(extension), ID{},
+                                         std::move(meta));
     }
 
 protected: