Add asprintf()
#4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
force-pushed
the
topic/timw/poll-asprintf
branch
from
301f0e2 to
ded96fe
Compare
awelzel
reviewed
Jan 30, 2025
unistd/unistd.cpp
Outdated
| va_start(ap, format); | ||
| int retval = vasprintf(strp, format, ap); | ||
| va_end(ap); | ||
| return returnval; |
There was a problem hiding this comment.
Suggested change
| return returnval; | |
| return retval; |
?
Is this still needed?
There was a problem hiding this comment.
It's not needed as I closed the PR this was needed for, but the change could still be useful.
timwoj
force-pushed
the
topic/timw/poll-asprintf
branch
from
ded96fe to
63a19b2
Compare
This should technically be in stdio.h but lives in unistd.h to avoid the filename collision that would be created by adding a stdio.h.
timwoj
force-pushed
the
topic/timw/poll-asprintf
branch
from
63a19b2 to
98b5456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of
asprintf. The implementation ofvasprintfalready exists, so this just adds the wrapper version of it. This function is a POSIX method, not part of the C standard. It's defined on all of our other platforms but not on Windows. This makes the changes in zeek/zeek#3137 smaller.