languages: Fix broken whitespace for C++#53709
Open
phdavis1027 wants to merge 1 commit intozed-industries:mainfrom
Open
languages: Fix broken whitespace for C++#53709phdavis1027 wants to merge 1 commit intozed-industries:mainfrom
phdavis1027 wants to merge 1 commit intozed-industries:mainfrom
Conversation
Uses tree-sitter indent queries to create a pseudo-scope, since access
modifiers are single-node in thetree-sitter grammar.
The @outdent capture truncates the parent { } indent range at the
access specifier, keeping it at the same level as the class keyword
and the pseudo-scopes from stacking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses tree-sitter indent queries to create a pseudo-scope, since access modifiers are single-node in thetree-sitter grammar.
The @outdent capture truncates the parent { } indent range at the access specifier, keeping it at the same level as the class keyword and the pseudo-scopes from stacking.
The @outdent range selects siblings so we don't outdent the access specifiers themselves, since screenshots from the reference issue seem to show that at least one interested party does not prefer outdented access modifiers, and also it seemed like less of a departure from existing design.
Also, there are probably more tests than needed because this is my first time writing treesitter queries and I wanted to triple-guess myself. Quite open too feedback on which ones are more valuable.
Self-Review Checklist:
Closes #53175
Release Notes: