Skip to content

git_graph: Hide commits that jj considers hidden#53692

Open
timvermeulen wants to merge 1 commit intozed-industries:mainfrom
timvermeulen:git-graph-use-jj-log-revset
Open

git_graph: Hide commits that jj considers hidden#53692
timvermeulen wants to merge 1 commit intozed-industries:mainfrom
timvermeulen:git-graph-use-jj-log-revset

Conversation

@timvermeulen
Copy link
Copy Markdown
Contributor

Not sure if this is something the team is interested in right now given the current lack of jj-specific features, but I'm opening this anyway because the git graph is the main git feature in Zed that isn't very usable currently in git-colocated jj repos. Jujutsu creates a lot of "hidden" commits that don't show up in the jj log output, but they do currently show up in the git graph in Zed 🙂

This is a simple proof of concept that uses the jj binary to obtain the visible_heads() revset to pass to git log. We'll probably want to use jj-lib for proper jj support (though I don't know how feature complete it currently is).

I went with the visible_heads() revset because it most closely matches the current git log --all output, but we could also use the revsets.log config value (wrapped in heads(...)) to more closely match the output of jj log. Or we could add a Zed setting for this.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Improved the git graph to hide commits that jj considers hidden.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 11, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Apr 11, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, Anthony-Eid and rtfeldman and removed request for a team April 11, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants