git_graph: Hide commits that jj considers hidden#53692
Open
timvermeulen wants to merge 1 commit intozed-industries:mainfrom
Open
git_graph: Hide commits that jj considers hidden#53692timvermeulen wants to merge 1 commit intozed-industries:mainfrom
timvermeulen wants to merge 1 commit intozed-industries:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is something the team is interested in right now given the current lack of jj-specific features, but I'm opening this anyway because the git graph is the main git feature in Zed that isn't very usable currently in git-colocated jj repos. Jujutsu creates a lot of "hidden" commits that don't show up in the
jj logoutput, but they do currently show up in the git graph in Zed 🙂This is a simple proof of concept that uses the
jjbinary to obtain thevisible_heads()revset to pass togit log. We'll probably want to use jj-lib for proper jj support (though I don't know how feature complete it currently is).I went with the
visible_heads()revset because it most closely matches the currentgit log --alloutput, but we could also use therevsets.logconfig value (wrapped inheads(...)) to more closely match the output ofjj log. Or we could add a Zed setting for this.Self-Review Checklist:
Release Notes:
jjconsiders hidden.