Skip to content

Handle new profile form in migrate_settings and migrate_language_setting#53681

Open
JosephTLyons wants to merge 2 commits intomainfrom
handle-new-profile-form-in-migrate-settings-and-migrate-language-setting
Open

Handle new profile form in migrate_settings and migrate_language_setting#53681
JosephTLyons wants to merge 2 commits intomainfrom
handle-new-profile-form-in-migrate-settings-and-migrate-language-setting

Conversation

@JosephTLyons
Copy link
Copy Markdown
Collaborator

@JosephTLyons JosephTLyons commented Apr 11, 2026

I noticed that there are helper migration functions that apply settings transformations to multiple layers (root, platform, release-channel, and profile):

migrate_settings
migrate_language_setting

Both of these handle the old settings profile forms, so I've updated them to handle either form, for usage in historical and future migrations.

Migration m_2026_04_10 actually introduced a wrapper function to provide to migrate_settings to handle both forms, which is what clued me into the fact that I missed these when I wrote the m_2026_04_01 originally (I didn't know they existed).

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • [N/A] Unsafe blocks (if any) have justifying comments
  • [N/A] The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

  • N/A

@JosephTLyons JosephTLyons requested a review from rtfeldman April 11, 2026 07:09
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 11, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant