Handle new profile form in migrate_settings and migrate_language_setting#53681
Open
JosephTLyons wants to merge 2 commits intomainfrom
Open
Handle new profile form in migrate_settings and migrate_language_setting#53681JosephTLyons wants to merge 2 commits intomainfrom
JosephTLyons wants to merge 2 commits intomainfrom
Conversation
…and-migrate-language-setting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there are helper migration functions that apply settings transformations to multiple layers (root, platform, release-channel, and profile):
migrate_settingsmigrate_language_settingBoth of these handle the old settings profile forms, so I've updated them to handle either form, for usage in historical and future migrations.
Migration
m_2026_04_10actually introduced a wrapper function to provide tomigrate_settingsto handle both forms, which is what clued me into the fact that I missed these when I wrote them_2026_04_01originally (I didn't know they existed).Self-Review Checklist:
Closes #ISSUE
Release Notes: