Open
Conversation
The go-subtest task template wrapped the -run arg in single quotes for shell safety. This works for Run Test (terminal strips quotes), but Debug Test sends the arg through Delve's DAP protocol with no shell involved, so the literal quote characters ended up in the regex and prevented any match. All other Go task templates (go-test, go-testify-suite, go-table-test-case) use the backslash-escaped format which the GoLocator already knows how to handle. Align the go-subtest template to the same format.
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
go-subtesttask template wrapped the-runarg in single quotes for shell safety. This works for Run Test (terminal strips quotes), but Debug Test sends the arg through Delve’s DAP protocol with no shell involved, so the literal quote characters ended up in the regex and prevented any match.All other Go task templates (
go-test,go-testify-suite,go-table-test-case) use the backslash-escaped format whichGoLocatoralready knows how to handle. Align thego-subtesttemplate to the same format.Self-Review Checklist:
Closes #53230.
Release Notes: