-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade tool versions #155
Conversation
Expecting this to fail, of course - at the very least the expected outputs have to be updated. The main questions for now are (a) whether the tests run through at all and (b) whether the results are compatible. |
In all tests, we currently get an error in rule |
The problem with kallisto index likely stems from this release that introduced a new and improved kallisto index: I have now set the version to the last version before the offending version ( Now, the question is whether they change in a way that we believe is worse than before. Do we have any way of assessing the testing quantitatively? How have we previously done this when upgrading tools (I'm sure this is not the first time)? Just ran a pipeline on one or more known samples and checked if the results look roughly the same and, if so, just upgraded? Because I think I would like to do that here as well. What do you think @mkatsanto? @balajtimate As discussed, I rolled back the changes to the HTSinfer Docker image from this PR, so that it'll still pull the latest image from the Zavolab registry after merging. We can put in a separate PR for that when the image is fixed on BioContainers. |
Actually, looking at the 57 files whose MD5 sum changed, it's not too bad at all:
So I think the question about still getting compatible outputs doesn't arise. Here's a list of the files whose MD5 check failed (renamed and grouped to make them easier to read/process): fastqc/fq1/single/fastqc_data.txt
fastqc/fq1/single/fastqc.fo
fastqc/fq1/single/Images/adapter_content.png
fastqc/fq1/single/Images/duplication_levels.png
fastqc/fq1/single/Images/per_base_n_content.png
fastqc/fq1/single/Images/per_base_sequence_content.png
fastqc/fq1/single/Images/per_sequence_gc_content.png
fastqc/fq1/single/Images/per_sequence_quality.png
fastqc/fq1/single/Images/sequence_length_distribution.png
fastqc/fq1/paired/fastqc_data.txt
fastqc/fq1/paired/fastqc.fo
fastqc/fq1/paired/Images/adapter_content.png
fastqc/fq1/paired/Images/duplication_levels.png
fastqc/fq1/paired/Images/per_base_n_content.png
fastqc/fq1/paired/Images/per_base_sequence_content.png
fastqc/fq1/paired/Images/per_sequence_gc_content.png
fastqc/fq1/paired/Images/per_sequence_quality.png
fastqc/fq1/paired/Images/sequence_length_distribution.png
fastqc/fq2/paired/fastqc_data.txt
fastqc/fq2/paired/fastqc.fo
fastqc/fq2/paired/Images/adapter_content.png
fastqc/fq2/paired/Images/duplication_levels.png
fastqc/fq2/paired/Images/per_base_n_content.png
fastqc/fq2/paired/Images/per_base_sequence_content.png
fastqc/fq2/paired/Images/per_sequence_gc_content.png
fastqc/fq2/paired/Images/per_sequence_quality.png
fastqc/fq2/paired/Images/sequence_length_distribution.png
fastqc_trimmed/fq1/single/fastqc_data.txt
fastqc_trimmed/fq1/single/fastqc.fo
fastqc_trimmed/fq1/single/Images/adapter_content.png
fastqc_trimmed/fq1/single/Images/duplication_levels.png
fastqc_trimmed/fq1/single/Images/per_base_n_content.png
fastqc_trimmed/fq1/single/Images/per_base_sequence_content.png
fastqc_trimmed/fq1/single/Images/per_sequence_gc_content.png
fastqc_trimmed/fq1/single/Images/per_sequence_quality.png
fastqc_trimmed/fq1/single/Images/sequence_length_distribution.png
fastqc_trimmed/fq1/paired/fastqc_data.txt
fastqc_trimmed/fq1/paired/fastqc.fo
fastqc_trimmed/fq1/paired/Images/adapter_content.png
fastqc_trimmed/fq1/paired/Images/duplication_levels.png
fastqc_trimmed/fq1/paired/Images/per_base_n_content.png
fastqc_trimmed/fq1/paired/Images/per_base_sequence_content.png
fastqc_trimmed/fq1/paired/Images/per_sequence_gc_content.png
fastqc_trimmed/fq1/paired/Images/per_sequence_quality.png
fastqc_trimmed/fq1/paired/Images/sequence_length_distribution.png
fastqc_trimmed/fq2/paired/fastqc_data.txt
fastqc_trimmed/fq2/paired/fastqc.fo
fastqc_trimmed/fq2/paired/Images/adapter_content.png
fastqc_trimmed/fq2/paired/Images/duplication_levels.png
fastqc_trimmed/fq2/paired/Images/per_base_n_content.png
fastqc_trimmed/fq2/paired/Images/per_base_sequence_content.png
fastqc_trimmed/fq2/paired/Images/per_sequence_gc_content.png
fastqc_trimmed/fq2/paired/Images/per_sequence_quality.png
fastqc_trimmed/fq2/paired/Images/sequence_length_distribution.png
multiqc_summary/multiqc_data/multiqc_fastqc_fastqc_raw.txt
multiqc_summary/multiqc_data/multiqc_fastqc_fastqc_trimmed.txt
salmon_indexes/homo_sapiens/31/salmon.idx/versionInfo.json |
Description
workflow/envs
sra-tools
andpigz
images from BioContainers (now all images except Ubuntu-based ones are from BioContainers)Fixes #154
Type of change
Conventional Commits guidelines
https://www.conventionalcommits.org/en/v1.0.0/
Checklist: