-
-
Notifications
You must be signed in to change notification settings - Fork 780
Feat: More controls for ui.scene
#4820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tests are failing https://github.com/evnchn/nicegui/actions/runs/15367841581 |
Wow, I didn't know that there are so many controls! Map controls seem to be very useful for 3D maps in RoSys! Anyway, I don't think we need all of them at once. If this PR can get some of them to work and lay the foundation for adding more of them later, this would be just fine. Regarding the implementation: Do we really need to import them in an |
Yes there were unwanted side effects: Failing tests and broken Since three.js is so much larger in comparison to the controls, it isn't worth it to investigate in dynamically loading just the control we are using IMO. If you think you can do it, feel free to take a shot. So far, only TrackballControls and MapControls work flawlessly, so those are the two I included in this PR. Ready for review IMO. |
ui.scene
ui.scene
Motivation
Addresses NiceGUI Wishlist (view), how we are stuck with OrbitControls
Implementation
setup_controls
andfetch_controls
toscene.js
THREE.Clock();
and feed the delta to get FlyControls and FirstPersonControls happy.this.controls.target?.
to get those happy.Progress
Issue: Some controls don't work properly. Do we want to drop them and release the working ones first, or spend more time get them working?
Test script:
We have decided to ship the working ones.
Feature request: #3710