Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been built?
This PR adds an integration test to test reading and writing xarray data in zarr. Works toward #2185
How was it done?
A new file
test_xarray.py
was added that includesA new environment called
downstream
was added in the pyproject.toml.How can it be tested?
hatch -e downstream run run
or:
hatch -e downstream shell
pytest -k xarray
Notes
This PR is still a draft. Todos before merging:
dataset()
fixture for multiple datatypes and array sizesstore()
fixture for multiple store typestest_roundtrip_v2()
for multiple chunk sizesWe are still unclear on how v3 will allow the user to set compression used by
xarray.Dataset.to_zarr
, so we have used the v2 standard. Pending changes on communication between xarray and zarr about compression alluded to by @jhamman.