feat: allow for configurable image push logic in the library #4002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
mkcp
reviewed
Jul 17, 2025
| @@ -55,6 +55,8 @@ type DeployOptions struct { | |||
| NamespaceOverride string | |||
| // Remote Options for image pushes | |||
| RemoteOptions | |||
| // [alpha] Whether to skip image push | |||
| NoImagePush bool | |||
There was a problem hiding this comment.
I know this corresponds directly to the param name in deployComponent but let's call the SDK-level configuration something active, likeDisableImagePush.
cc @zarf-dev/maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an [alpha] level suggestion to allow a little more direct control over image pushing in the Zarf deployment API.
This is useful if you know the registry you are pushing to already has the images you need and you want to slim down parts of the Zarf package deploy.
Related Issue
Fixes #N/A
Checklist before merging