feat: add arch variable to variables

[a1994sc]

Description

This PR adds in the zarf variable ZARF_ARCHITECTURE, this helps with deploying the zarf package into a multi-arch cluster.

Related Issue

Relates to #3817

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	b3293c8
🔍 Latest deploy log	https://app.netlify.com/projects/zarf-docs/deploys/687ff2c705d8c7000833270d

[a1994sc]

I need to add logic to the injector to use the arch of the package.

Added injector logic

[codecov]

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pkg/packager/deploy.go	0.00%	9 Missing ⚠️
src/internal/packager/helm/zarf.go	0.00%	7 Missing ⚠️

Files with missing lines	Coverage Δ
src/pkg/cluster/injector.go	64.92% <100.00%> (+0.20%)	⬆️
src/internal/packager/helm/zarf.go	0.00% <0.00%> (ø)
src/pkg/packager/deploy.go	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[a1994sc]

Hm, so I after reviewing the logs from the last e2e test I see that for the arch value was not being passed along correctly. I updated the logic such that the injector, docker registry, and gitea all get deployed.... however the agent gets deployed fine once, however during part of the make test-e2e-with-cluster ARCH=amd64 the agent pods get into a pending state because the kubernetes.io/arch is set to ""... any input would be super helpful

[a1994sc]

[a1994sc]

I updated this PR so now ZARF_ARCHITECTURE is only set for the life-cycle of the package deployment.

Edit:

Though, I am getting the following error when doing an end-2-end test:

4s          Warning   FailedCreate        replicaset/source-controller-869c75dd44             Error creating: Internal error occurred: failed calling webhook "agent-pod.zarf.dev": failed to call webhook: Post "https://agent-hook.zarf.svc:443/mutate/pod?timeout=10s": tls: failed to verify certificate: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "ca.private.zarf.dev")

[AustinAbro321]

This seems like it'll be a huge value add for Zarf, thanks for the PR. Once CI is passing, I'll try to test locally and send you an updated eks.yaml which would let us spin up a multi-arch cluster so we can have a proper e2e test.

[a1994sc]

Yea no problem! This does not fully address having a truly multi-arch support, but is a step in that direction.

(A bit selfishly I would love to see zarf running a multi-arch cluster at home, RPI and intel NUC)

[a1994sc]

Todo: update the variable to ZARF_PKG_ARCHITECTURE per convo on slack channel

ref: https://kubernetes.slack.com/archives/C03B6BJAUJ3/p1752503299318649?thread_ts=1752502999.838289&cid=C03B6BJAUJ3

[AustinAbro321]

A few small notes, I will make it an action item on my side to get you a new eks.yaml that can properly test a multi-node cluster with Zarf

[AustinAbro321]

Realized something after https://github.com/zarf-dev/zarf/actions/runs/16351367206/job/46203688496 failed

[AustinAbro321]

Out of an abundance of caution we should not continue if nodeDetails.Status.NodeInfo.Architecture=="". Hopefully that never happens, but I don't want to break anybody if they're on a cluster where this isn't set for some reason.

[a1994sc]

So I believe that this is a result of using a bare-bones "cluster" for tests. I believe that a really node will always have an Architecture.... I will do some research to verify that though