Mermaid test branch #3824
Closed
Mermaid test branch #3824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [dompurify](https://github.com/cure53/DOMPurify) to 3.2.5 and updates ancestor dependency [mermaid](https://github.com/mermaid-js/mermaid). These dependencies need to be updated together. Updates `dompurify` from 3.1.6 to 3.2.5 - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.1.6...3.2.5) Updates `mermaid` from 10.9.3 to 11.6.0 - [Release notes](https://github.com/mermaid-js/mermaid/releases) - [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md) - [Commits](https://github.com/mermaid-js/mermaid/compare/[email protected]) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.2.5 dependency-type: indirect - dependency-name: mermaid dependency-version: 11.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <[email protected]>
|
Closing as none of the workarounds I tried resolved the issue with how the mermaid diagrams are now rendered (expected). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing mermaid diagram configurations
Between v10.x and v11.x the switch (and upgrade) of the layout engine (dagre → dagre/elk, plus internal refactors) changed how ports and bend points are chosen. The algorithm now aggressively avoids node overlaps and minimizes crossings by routing the loop all the way around, yielding those giant, erratic curves instead of a tidy arc.
Related Issue
Relates to #3696
Checklist before merging