-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor package loading process w provider pattern (the real MZAL) #1977
Merged
Racer159
merged 198 commits into
main
from
1943-refactor-package-loading-process-w-provider-pattern
Oct 2, 2023
Merged
Refactor package loading process w provider pattern (the real MZAL) #1977
Racer159
merged 198 commits into
main
from
1943-refactor-package-loading-process-w-provider-pattern
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Noxsios
added
jackal
and removed
needs-adr
needs-docs
PR Label - Docs required to merge
labels
Sep 28, 2023
Signed-off-by: razzle <[email protected]>
Racer159
requested changes
Sep 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes - overall very close
Co-authored-by: Wayne Starr <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Racer159
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Racer159
deleted the
1943-refactor-package-loading-process-w-provider-pattern
branch
October 2, 2023 22:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Big refactor in how packages are retrieved and loaded under the hood. This shift to an interface pattern allows for the same behavior to be exhibited by packages from a variety of sources. Feature parity is assured, and packages can be
deploy
ed,inspect
ed,publish
ed, andremove
d via a reference to any source type.The core + internally supported source types:
.tar.zst
,.tar
)However, with the addition of
WithSource(source sources.PackageSource)
any library user ofpackager.New
can create and set their own source. With this, any possible source can be supported: SSH sources, distributed packages, S3 buckets...Additionally, there is current behavior that allows for the
remove
al of packages deployed, i.e.zarf package remove dos-games
. This ability to specify a package via its name is now available oninspect
:zarf package inspect dos-games
. Inspecting / extracting SBOMs is currently a no-op as SBOMs are not persisted to the cluster.Related Issue
Fixes #1832
Fixes #1943
Fixes #1757
Fixes #2029
Type of change
Checklist before merging