Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors and library additions to support bundles #1770

Merged
merged 209 commits into from
Aug 15, 2023
Merged

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Jun 2, 2023

Description

This PR performs some refactoring in packager, oci and a few other places to allow for orchestration of Zarf packages in bundles. A POC of this bundle effort is/was contained in this PR, but will/has been migrated to a new CLI, and as such been removed from this PR. The final state of this PR will allow for easier consumption of certain functionality in packager, more powerful oci library features, and is one of the first true tests of Zarf as a library. 2 months well spent.

Closes #1908

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before merging

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 7bff987
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/64dbcec5c4246c0008cdc93a

Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
docs/gen-cli-docs.sh Outdated Show resolved Hide resolved
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small notes

src/cmd/bundle.go Outdated Show resolved Hide resolved
src/cmd/bundle.go Outdated Show resolved Hide resolved
src/cmd/bundle.go Outdated Show resolved Hide resolved
src/cmd/bundle.go Outdated Show resolved Hide resolved
src/pkg/bundler/common.go Outdated Show resolved Hide resolved
src/pkg/bundler/common.go Outdated Show resolved Hide resolved
src/pkg/bundler/fs.go Outdated Show resolved Hide resolved
Signed-off-by: razzle <[email protected]>
Signed-off-by: razzle <[email protected]>
src/cmd/version.go Outdated Show resolved Hide resolved
src/pkg/oci/copier.go Outdated Show resolved Hide resolved
src/pkg/oci/copier.go Outdated Show resolved Hide resolved
src/pkg/oci/pull.go Outdated Show resolved Hide resolved
src/pkg/oci/utils.go Outdated Show resolved Hide resolved
src/pkg/utils/io.go Outdated Show resolved Hide resolved
src/test/e2e/00_use_cli_test.go Show resolved Hide resolved
src/types/runtime.go Outdated Show resolved Hide resolved
src/types/runtime.go Outdated Show resolved Hide resolved
src/types/runtime.go Outdated Show resolved Hide resolved
src/pkg/packager/network.go Fixed Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 575cdef into main Aug 15, 2023
29 checks passed
@Racer159 Racer159 deleted the feature/bundle branch August 15, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When zarf package publish is used as library, no additional cli commands should be printed
4 participants