ci: add rust linting and deps workflows #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
approved these changes
Mar 19, 2025
|
|
||
| - name: Clippy | ||
| id: clippy | ||
| run: cargo clippy -- -D warnings |
There was a problem hiding this comment.
Maybe we could add --all-targets --all-features.
There was a problem hiding this comment.
Actually, maybe --all-features won't work due to us not using nightly.
There was a problem hiding this comment.
--all-targets is failing because can't compile fhevm-engine-common
tawadaa
force-pushed
the
aw/ci/cargo-linting-deps
branch
from
35223e4 to
e0fea37
Compare
tawadaa
force-pushed
the
aw/ci/cargo-linting-deps
branch
from
e0fea37 to
df36159
Compare
|
@tawadaa Do we want to reinstate work on this PR or we can do it at a later stage? |
|
Closing this one. We can still use the code here in the migrated repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.