Skip to content

chore: commit missing Cargo.lock updates #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

dartdart26
Copy link
Collaborator

@dartdart26 dartdart26 commented Mar 17, 2025

In order to do so:
* Update to rust:1.85.0-bookworm and debian:bookworm-slim.
* Specify a solc version of 0.8.28 due to libc and libstdc++ issues
with the rust Docker image.

The idea of updating to bookworm is that the bullseye version is now old.

@dartdart26 dartdart26 self-assigned this Mar 17, 2025
@dartdart26 dartdart26 requested a review from a team as a code owner March 17, 2025 10:20
@cla-bot cla-bot bot added the cla-signed label Mar 17, 2025
Copy link
Contributor

@rudy-6-4 rudy-6-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But if you want it to be perennial. You could copy from
fhevm-relayer/.github/workflows/dependency_analysis.yml

@dartdart26
Copy link
Collaborator Author

LGTM. But if you want it to be perennial. You could copy from fhevm-relayer/.github/workflows/dependency_analysis.yml

Let's do it in another PR?

@dartdart26 dartdart26 force-pushed the petar/cargo-lock branch 2 times, most recently from 5c7cd67 to bf1adac Compare March 18, 2025 15:38
In order to do so:
 * Update to rust:1.85.0-bookworm and debian:bookworm-slim.
 * Specify a solc version of 0.8.28 due to libc and libstdc++ issues
   with the rust Docker image.

The idea of updating to bookworm is that the bullseye version is now
old.
@tawadaa
Copy link
Collaborator

tawadaa commented Mar 18, 2025

LGTM. But if you want it to be perennial. You could copy from fhevm-relayer/.github/workflows/dependency_analysis.yml

@rudy-6-4 it's WIP in this PR

Copy link
Collaborator

@tawadaa tawadaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs to be tested in staging though

@dartdart26 dartdart26 merged commit e80e31e into main Mar 18, 2025
13 checks passed
@dartdart26 dartdart26 deleted the petar/cargo-lock branch March 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants