Simplifies makeBackendRequest #1556

AlexanderYastrebov · 2020-10-17T21:27:32Z

Folds net.Error handling
Adds getRoundTripper method

Signed-off-by: Alexander Yastrebov [email protected]

* Folds net.Error handling * Adds getRoundTripper method Signed-off-by: Alexander Yastrebov <[email protected]>

proxy/proxy.go

-		if err != nil {
-			p.log.Errorf("Failed to roundtrip to fastcgi: %v", err)
-
-			return nil, &proxyError{err: err}


AlexanderYastrebov · 2020-10-19T13:12:13Z

Some points on extracting getRoundTripper are:

for fascgi previously it was a mix of roundtripper creation failure and roundtrip failure, now these are separated
for fastcgi roundtrip failure prevented common error and open tracing handling because of early return
previously there was no clear point before and after roundtrip where instrumentation could plug in, now it is clear as it was before fastcgi addition
this change makes a step towards custom rountrip timeouts More fine-grained timeout handling #1041

AlexanderYastrebov · 2020-10-23T12:40:32Z

Will open a new one with better test coverage

Simplifies makeBackendRequest

3ad916b

* Folds net.Error handling * Adds getRoundTripper method Signed-off-by: Alexander Yastrebov <[email protected]>

AlexanderYastrebov commented Oct 17, 2020

View reviewed changes

proxy/proxy.go

if err != nil {

p.log.Errorf("Failed to roundtrip to fastcgi: %v", err)

return nil, &proxyError{err: err}

This comment was marked as duplicate.

Sign in to view

AlexanderYastrebov closed this Oct 23, 2020

AlexanderYastrebov deleted the prettify-make-backend-request branch October 23, 2020 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplifies makeBackendRequest #1556

Simplifies makeBackendRequest #1556

AlexanderYastrebov commented Oct 17, 2020

This comment was marked as duplicate.

AlexanderYastrebov commented Oct 19, 2020 •

edited

Loading

AlexanderYastrebov commented Oct 23, 2020

Simplifies makeBackendRequest #1556

Simplifies makeBackendRequest #1556

Conversation

AlexanderYastrebov commented Oct 17, 2020

This comment was marked as duplicate.

AlexanderYastrebov commented Oct 19, 2020 • edited Loading

AlexanderYastrebov commented Oct 23, 2020

AlexanderYastrebov commented Oct 19, 2020 •

edited

Loading