Added try-finally to span finish

zalando · Nov 26, 2019 · 251b654 · 251b654
1 parent 8070e93
commit 251b654
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/...racing-jdbc/src/main/java/org/zalando/opentracing/jdbc/TracingQueryExecutionListener.java b/...racing-jdbc/src/main/java/org/zalando/opentracing/jdbc/TracingQueryExecutionListener.java
@@ -48,14 +48,16 @@ public void beforeQuery(final ExecutionInfo info, final List<QueryInfo> infos) {
     public void afterQuery(final ExecutionInfo info, final List<QueryInfo> queries) {
         final Span span = info.getCustomValue(SPAN, Span.class);
 
-        if (!info.isSuccess()) {
-            final Statement statement = info.getStatement();
-            final Throwable error = info.getThrowable();
-
-            decorator.onError(span, statement, error);
+        try {
+            if (!info.isSuccess()) {
+                final Statement statement = info.getStatement();
+                final Throwable error = info.getThrowable();
+
+                decorator.onError(span, statement, error);
+            }
+        } finally {
+            span.finish();
         }
-
-        span.finish();
     }
 
 }