Scale for elastigroup #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 18, 2018 21:34
|
👍 |
jmcs
reviewed
Jul 20, 2018
senza/cli.py
Outdated
| @@ -25,7 +25,7 @@ | |||
| fatal_error, info, ok) | |||
| from clickclick.console import print_table | |||
|
|
|||
| import spotinst | |||
| from spotinst.components import elastigroup_api | |||
There was a problem hiding this comment.
This should be from .spotinst.components import elastigroup_api since it's a relative import.
There was a problem hiding this comment.
This won't work because the spotinst package is outside the senza package. Let's merge this one as a absolute import, and move the spotinst package inside senza in the next PR (there are a few more functionalities to be changed)
|
👍 |
1 similar comment
|
👍 |
|
/cc @ruiaraujo |
talzur
reviewed
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #517