Added a part to download current page #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for taking so long to look at this. Have you considered using the context menu? I think that would be a better place for it. Also, the URL is not enough to identify the original request for a given page. Perhaps check the tab ID too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a Proposition to solver issue #57 or even #51.
The code is definitive, I just wanted to know if it's possible.
I stored page requests in a separated list from downloads but we could maybe merge the two lists in a single one.
I made basic design for separating current page from downloads. Maybe we could add title to let the user know what's there.
I tested in on FF57 and it's working fine.
Let me know if you would like to include such feature and how I can make it done.