This repository was archived by the owner on Jul 18, 2022. It is now read-only.
python::pip: Implement group support #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest virtualenv is 20.0.23. This version leads to the following error:
```
Error: Facter: error while resolving custom fact "virtualenv_version": undefined method `[]' for nil:NilClass
```
I reproduced it in irb:
```
irb(main):001:0> `virtualenv --version 2>&1`.match(%r{^(\d+\.\d+\.?\d*).*$})
=> nil
irb(main):002:0> `virtualenv --version 2>&1`
=> "virtualenv 20.0.23 from /usr/lib/python3.8/site-packages/virtualenv/__init__.py\n"
irb(main):003:0> `virtualenv --version 2>&1`.match(%r{(\d+\.\d+\.?\d*).*$})
=> #<MatchData "20.0.23 from /usr/lib/python3.8/site-packages/virtualenv/__init__.py" 1:"20.0.23">
irb(main):004:0> `virtualenv --version 2>&1`.match(%r{(\d+\.\d+\.?\d*).*$})[1]
=> "20.0.23"
irb(main):005:0>
```
This code not only fixes it, it's a direct copy from voxpupuli/python.
merging this brings us also closer to solving zachfi#49
Contributor
Author
|
how did I create this confict |
In my long term effort to merge this module with voxpupuli/python, I'm adding a parameter that's present in the voxpupuli module. Now it's possible to set a group for installed pips and not only the owner. this is breaking change for people that currently have owner != root. I plan to propose more PRs in the future, so please don't release this one yet.
Owner
|
Hi @bastelfreak, thanks for the PR. I fully support this effort. I'm not quite sure how the conflict happened, but do you want to try a rebase on master and see where we land? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my long term effort to merge this module with voxpupuli/python, I'm
adding a parameter that's present in the voxpupuli module. Now it's
possible to set a group for installed pips and not only the owner.
this is breaking change for people that currently have owner != root. I
plan to propose more PRs in the future, so please don't release this one
yet.