Conversation
added 24 commits
February 20, 2024 15:36
alex0207s
commented
Mar 6, 2024
Collaborator
Author
There was a problem hiding this comment.
DO NOT push this file on Github
|
|
||
| function test_TransferAcrossMultipleAccounts() public { | ||
| vm.startPrank(user1); | ||
| token.mint(user1, 10 * 10 ** 18); |
Collaborator
Author
There was a problem hiding this comment.
you can replace ether with 10**18.
| } | ||
|
|
||
| function mint(address to, uint256 amount) public { | ||
| require(balanceOf(msg.sender) + amount <= 10 * 10 ** 18, "You can only mint less than 10"); |
Collaborator
Author
There was a problem hiding this comment.
- DON'T rely solely on the
balanceOfto determine the number of tokens a user can mint. Depending solely on this could cause a vulnerability, especially when a user transfers out the minted tokens and continues to mint more tokens. - This require statement will restrict the contract owner to mint more than 10 tokens. However we allow the contract owner mint more than 10 tokens.
- use custom errors are more gas efficient than using require with a string
|
|
||
| contract Token is ERC20 { | ||
| constructor() ERC20("Token", "TK") { | ||
| _mint(msg.sender, 100 * (10 ** uint256(decimals()))); |
Collaborator
Author
There was a problem hiding this comment.
If you don't override the decimals() function, you can use the ether keyword directly.
| // console2.logBytes(abi.encodeWithSelector(selector, address(0x6813Eb9362372EEF6200f3b1dbC3f819671cBA69), 1, 6)); | ||
| // vm.expectRevert(abi.encodeWithSelector(selector, 0x6813Eb9362372EEF6200f3b1dbC3f819671cBA69, 1, 6)); | ||
| vm.expectRevert(abi.encodeWithSelector(selector, user2, token.allowance(user1, user2), token.balanceOf(user1))); | ||
| token.transferFrom(user1, user2, token.balanceOf(user1)); |
Collaborator
Author
There was a problem hiding this comment.
user1 approves user2 to spend only 3 tokens. You cannot transfer user1's total balance to user2.
| 1. user2 將 user1 的 2 個 token 轉移到 user3 身上，並將剩餘的 token 轉移給自己 | ||
| 2. 因 allowance 不足，會導致 ERC20InsufficientAllowance revert | ||
| - 將 user1 的 balance 分別用 Ether、Gwei 為單位表示 | ||
| 1. cast call 0xaFfB198193e8681f58DB28DBBaf72be91699Fb73 "balanceOf(address)(uint256)" --rpc-url="https://eth-sepolia.g.alchemy.com/v2/your_alchemy_api_key" 0x0278137e8E2C38111297c9991815507eB16eaf25 得到 6000000000000000000 |
Collaborator
Author
There was a problem hiding this comment.
I recommend using .md instead of .txt and enclosing command lines within backticks for easier readability (e.g. forge test)
alex0207s
commented
Mar 6, 2024
Collaborator
Author
There was a problem hiding this comment.
Do not push this file to GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.