Skip to content

Commit

Permalink
Push built images to prod GCR
Browse files Browse the repository at this point in the history
- We only push to prod, not staging, since chartpress isn't set up
  to do multiple pushes. jupyterhub/chartpress#25
  should help with that.
- Staging can read all prod images for now, to work around this.
- Create and use a new prod service acct that has image read / write perms.
  • Loading branch information
yuvipanda committed Nov 1, 2018
1 parent 7084cbc commit 3b2e751
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ before_deploy:
(cd mybinder && helm dep up)
- |
# Stage 3, Step 1: Build images if needed
# We build and push our misc images to prod only for now.
# Staging has readonly access to prod images.
docker login -u _json_key --password-stdin https://gcr.io < secrets/gcr-auth-key-prod.json
chartpress --commit-range ${TRAVIS_COMMIT_RANGE}
# Doing this here, since git crypt doesn't like unclean checkouts
- |
Expand Down
2 changes: 1 addition & 1 deletion chartpress.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
charts:
- name: mybinder
imagePrefix: jupyterhub/mybinder-extr
imagePrefix: jupyterhub/mybinder-tool-
images:
events-archiver:
valuesPath: eventsArchiver.image
Binary file added secrets/gcr-auth-key-prod.json
Binary file not shown.

0 comments on commit 3b2e751

Please sign in to comment.