-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paste feature requested on #48 #52
Conversation
ranga543
commented
Jan 28, 2022
- paste on octet inputs or cidr input
- handles just octet paste or full cidr ip paster
Thanks for working on this issue! As for the solution, instead of rolling your own regex, I suggest using the |
@yuvadm can this be merged after resolving merge conflicts? It's been open for a long time. |
@aravindvnair99 as mentioned in my previous comment, I prefer to see validation with |
@ranga543 would you be able to update your code with the same and also resolve the conflict? |
@yuvadm Updated code to use netmask instead of regex |
@yuvadm were you able to check this? Could you also trigger a rerun of the deployment? |
@aravindvnair99 yes, the netlify build settings have been updated and current build can be seen on https://deploy-preview-52--cidr.netlify.app/ Any future commits to this branch will probably update the PR properly. Overall looks good! |
When can this be released? I've been using this tool a lot and pasting CIDRs would make things a lot easier! As far as I can see the deployed preview is working great. |
Not sure why I haven't merged it yet, sorry about that 😅 Merging now, thanks for the reminder! |
Awesome thank you! 🙌 |