Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paste feature requested on #48 #52

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

ranga543
Copy link
Contributor

  • paste on octet inputs or cidr input
  • handles just octet paste or full cidr ip paster

@yuvadm
Copy link
Owner

yuvadm commented Feb 1, 2022

Thanks for working on this issue! As for the solution, instead of rolling your own regex, I suggest using the netmask library which is already available as a dependency.

@aravindvnair99
Copy link
Collaborator

@yuvadm can this be merged after resolving merge conflicts? It's been open for a long time.

@yuvadm
Copy link
Owner

yuvadm commented Mar 5, 2023

@aravindvnair99 as mentioned in my previous comment, I prefer to see validation with netmask as opposed to a custom regex

@aravindvnair99
Copy link
Collaborator

@ranga543 would you be able to update your code with the same and also resolve the conflict?

@aravindvnair99
Copy link
Collaborator

@yuvadm need you to update the build image so that changes can be tested properly. I've opened #66 to track this.

@ranga543
Copy link
Contributor Author

ranga543 commented Mar 6, 2023

@yuvadm Updated code to use netmask instead of regex

@aravindvnair99
Copy link
Collaborator

Thanks @ranga543! @yuvadm could you review this?

@aravindvnair99
Copy link
Collaborator

@yuvadm were you able to check this? Could you also trigger a rerun of the deployment?

@yuvadm
Copy link
Owner

yuvadm commented Mar 14, 2023

@aravindvnair99 yes, the netlify build settings have been updated and current build can be seen on https://deploy-preview-52--cidr.netlify.app/

Any future commits to this branch will probably update the PR properly.

Overall looks good!

@KevinGimbel
Copy link

When can this be released? I've been using this tool a lot and pasting CIDRs would make things a lot easier!

As far as I can see the deployed preview is working great.

@yuvadm
Copy link
Owner

yuvadm commented May 30, 2023

Not sure why I haven't merged it yet, sorry about that 😅

Merging now, thanks for the reminder!

@yuvadm yuvadm merged commit 8a4372c into yuvadm:master May 30, 2023
@KevinGimbel
Copy link

Awesome thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature to paste CIDR range No easy way to copy-paste CIDR in and out
4 participants