Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Signal issue with Sanic 21.9 #63

Closed
wants to merge 1 commit into from

Conversation

wochinge
Copy link

@wochinge wochinge commented Nov 5, 2021

Proposed Changes

@wochinge
Copy link
Author

wochinge commented Nov 5, 2021

Should I also update poetry.lock? We might also wanna double check if this actually works with older Sanic versions

indam23 added a commit to RasaHQ/pytest-sanic that referenced this pull request Jul 1, 2022
@indam23
Copy link

indam23 commented Jul 1, 2022

I've ported this fix to #66 and added the changes mentioned in the issue

@wochinge
Copy link
Author

wochinge commented Jul 1, 2022

@ancalita @melindaloubser1 there is also an official test library for Sanic (https://sanic.dev/en/plugins/sanic-testing/getting-started.html) which I’d recommend to use instead of pytest-sanic. I switched out the Rasa X code with that one and it was relatively straight forward if I remember correctly

@indam23
Copy link

indam23 commented Jul 4, 2022

Thanks for the tip @wochinge 🙏

@ottonemo
Copy link

@yunstanford do you think this can be merged? This prevents people from using current sanic versions :)

@wochinge wochinge closed this Jun 27, 2023
@wochinge wochinge deleted the fix-signal-issue branch June 27, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with sanic>21.6
3 participants