-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple dates in cvEntry
#88
Conversation
Actually I thought of having this kind of feature, but put it on hold for complexity reason. To me, it will be superb to have one entry with multiple dates; but that ideally if we have also have separate I haven't got the occasion to think this over, but definitely open to your idea! |
I absolutely agree that this would be an amazing feature! In your example, though, we wouldn’t just need a different At the moment, I’m not entirely sure how to implement something like this (I only started using typst a few days ago). If I come up with a solution, I’ll happily open another PR. For now, though, I believe this lies outside the scope of this current PR. |
I understand. Will take a look on this in the following days to see if I can come up with a better solution; otherwise I will accept this PR as it is. |
6eae923
to
cc3f553
Compare
cc3f553
to
7094b9d
Compare
I gave it some thought, and so far the best I can come up with is an array of dictionaries: #let cvEntryComplex(
society: "Society",
location: "Location",
logo: "",
tags: (),
positions: ((title: "Title", date: "Date(s)", description: "Description")),
metadata: metadata,
awesomeColors: awesomeColors,
) = {
[TODO]
} As I mentioned earlier, it might even make sense to include the location in this dictionary. (Maybe even the tags?) |
7094b9d
to
bcdfaf0
Compare
Implement a new function `cvEntryContinued` that allows for creating continued entries in the CV with flexible styling and layout options. The function supports: - Customizable entry details (title, society, date, location) - Optional logo display - Styling for tags and descriptions - Conditional layout based on metadata settings Signed-off-by: yunanwg <[email protected]>
I have the impression that my implementation might not be exactly what you had in mind. Do tell me what you think and how we can better consolidate these less-frequent features! |
I'm not entirely sure what you meant by that, but I believe I circumvented the issue by adding
Instead of fixing the width of the first column, I opted to constrain the second column since dates tend to have a more predictable length. While I only speak English among English, Chinese, French, and Italian, I tried to find the longest possible date formats across these languages (with the help of LLMs). |
I think that the introduction of Appreciated the fix of the column length for dates! I will review the changes right away. |
… width to the same as for English
This pull request introduces support for multiple dates for a single position. The feature reduces redundancy and saves space for recurring roles such as internships and teaching assistant positions.
To achieve this, a
cvEntry
is split into two columns: the first column contains thelogo
,title
,society
,description
, andtags
, while the second column displays thelocation
anddate
(s) only.