Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Score option is not reflected #8

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix Score option is not reflected #8

merged 2 commits into from
Jan 23, 2021

Conversation

yukihirop
Copy link
Owner

@yukihirop yukihirop commented Jan 23, 2021 •
edited
Loading

Summary

Test

Currently there are no tests.
Instead, the operation is guaranteed by executing the following command and actually checking the operation.

  • python3 gfzs/views/not_found.py
  • python3 gfzs/views/paging.py
  • python3 gfzs/views/footer.py
  • python3 gfzs/views/header.py
  • python3 gfzs/views/search_result.py
  • python3 gfzs/utils/markup.py
  • python3 gfzs/utils/color.py
  • python3 gfzs/config/app.py
  • python3 gfzs/cmd/init.py
  • python3 gfzs/cmd/edit.py
  • python3 gfzs/cmd/demo.py
  • python3 gfzs/cmd/valid.py
  • python3 gfzs/controller.py
  • python3 gfzs/model.py
  • cat fixtures/rust.json | bin/gfzs -s 20
  • cat fixtures/rust.json | python3 -m gfzs -s 40
  • bin/gfzs init
  • bin/gfzs edit
  • bin/gfzs demo
  • bin/gfzs valid
  • black gfzs/**/*.py

TestPyPi

https://test.pypi.org/project/gfzs/

$ pip install gfzs==0.2.1 --extra-index-url  https://test.pypi.org/simple
Looking in indexes: https://pypi.org/simple, https://test.pypi.org/simple
Collecting gfzs==0.2.1
  Downloading https://test-files.pythonhosted.org/packages/96/1d/23c17f1463dccc231a4cf9ab9e8bfb4341193300db62af0e8836caac4ccc/gfzs-0.2.1-py3-none-any.whl (44 kB)
     |████████████████████████████████| 44 kB 3.4 MB/s
Requirement already satisfied: fuzzywuzzy<0.19.0,>=0.18.0 in ./.venv/lib/python3.7/site-packages (from gfzs==0.2.1) (0.18.0)
Requirement already satisfied: python-Levenshtein<0.13.0,>=0.12.1 in ./.venv/lib/python3.7/site-packages (from gfzs==0.2.1) (0.12.1)
Requirement already satisfied: flatten-dict<0.4.0,>=0.3.0 in ./.venv/lib/python3.7/site-packages (from gfzs==0.2.1) (0.3.0)
Requirement already satisfied: pathlib2<3.0,>=2.3 in ./.venv/lib/python3.7/site-packages (from flatten-dict<0.4.0,>=0.3.0->gfzs==0.2.1) (2.3.5)
Requirement already satisfied: six<2.0,>=1.12 in ./.venv/lib/python3.7/site-packages (from flatten-dict<0.4.0,>=0.3.0->gfzs==0.2.1) (1.15.0)
Requirement already satisfied: setuptools in ./.venv/lib/python3.7/site-packages (from python-Levenshtein<0.13.0,>=0.12.1->gfzs==0.2.1) (40.8.0)
Installing collected packages: gfzs
  Attempting uninstall: gfzs
    Found existing installation: gfzs 0.2.0
    Uninstalling gfzs-0.2.0:
      Successfully uninstalled gfzs-0.2.0
Successfully installed gfzs-0.2.1

@yukihirop yukihirop added the bug Something isn't working label Jan 23, 2021
@yukihirop yukihirop added this to the 0.2.1 milestone Jan 23, 2021
@yukihirop yukihirop self-assigned this Jan 23, 2021
@yukihirop
Copy link
Owner Author

LGTM

@yukihirop yukihirop merged commit 5c08eb0 into main Jan 23, 2021
@yukihirop yukihirop deleted the issues7/fix_bug_about_score_option branch January 23, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yukihirop yukihirop

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.

Score option is not reflected
1 participant
@yukihirop