Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl valid and demo cmd #3

Merged
merged 12 commits into from
Jan 22, 2021
Merged

Impl valid and demo cmd #3

merged 12 commits into from
Jan 22, 2021

Conversation

yukihirop
Copy link
Owner

@yukihirop yukihirop commented Jan 22, 2021

Summary

Resolve #1

Work

Implement cmd

  • gfzs demo
  • gfzs valid
$ bin/gfzs valid
Config is valid.
$ bin/gfzs valid
Config is invalid.
Error: Contains unsupported value. (key_path, value) = (view.footer.color.hline.style, normalaaaaaa)
$ bin/gfzs valid
Config is invalid.
Error: Contains unsupported keys. key path: 'view.footer.color.message.styleaaaaaaaa'.
$ bin/gfzs valid
Config is invalid.
Error: Contains unsupported keys. key_path = 'view.bar'.

Test

Currently there are no tests.
Instead, the operation is guaranteed by executing the following command and actually checking the operation.

  • python3 gfzs/views/not_found.py
  • python3 gfzs/views/paging.py
  • python3 gfzs/views/footer.py
  • python3 gfzs/views/header.py
  • python3 gfzs/views/search_result.py
  • python3 gfzs/utils/markup.py
  • python3 gfzs/utils/color.py
  • python3 gfzs/config/app.py
  • python3 gfzs/cmd/init.py
  • python3 gfzs/cmd/edit.py
  • python3 gfzs/controller.py
  • python3 gfzs/model.py
  • cat fixtures/rust.json | bin/gfzs -s 20
  • cat fixtures/rust.json | python3 -m gfzs -s 40
  • black gfzs/**/*.py

@yukihirop yukihirop added this to the 0.1.1 milestone Jan 22, 2021
@yukihirop yukihirop self-assigned this Jan 22, 2021
@yukihirop
Copy link
Owner Author

yukihirop commented Jan 22, 2021

  • python3 gfzs/cmd/demo.py
  • python3 gfzs/cmd/valid.py
  • bin/gfzs init
  • bin/gfzs edit
  • bin/gfzs demo
  • bin/gfzs valid

@yukihirop
Copy link
Owner Author

when config validation error

e.g.)

Config is invalid.
Error: Contains unsupported key.   (key_path, value) = (view.footer.messagea, QUERY>).
Error: Contains unsupported value. (key_path, value) = (view.footer.color.message.background, -1).
Error: Contains unsupported value. (key_path, value) = (view.footer.color.hline.background, -1).
Error: Contains unsupported value. (key_path, value) = (view.footer.color.hline.style, normalaaaa).
Error: Contains unsupported key.   (key_path, value) = (view.header.color.hline.textaa, 7).
Error: Contains unsupported key.   (key_path, value) = (view.header.color.hline.styleaaa, normal).
Error: Contains unsupported key.   (key_path, value) = (view.search_result.color.index.backgrouaaaand, 0).

@yukihirop
Copy link
Owner Author

LGTM

@yukihirop yukihirop merged commit a8516b8 into main Jan 22, 2021
@yukihirop yukihirop deleted the impl_valid_and_demo_cmd branch January 22, 2021 18:40
@yukihirop yukihirop modified the milestones: 0.1.1, 0.2.0 Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement valid & demo command
1 participant