Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Singleton Class #20

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Modify Singleton Class #20

merged 5 commits into from
Feb 1, 2021

Conversation

yukihirop
Copy link
Owner

@yukihirop yukihirop commented Feb 1, 2021 •
edited
Loading

Summary

Resolve #18

Refactor Singleton Class

  • RuntimeConfig
  • RuntimeOpts
  • Color

Test

Currently there are no tests.
Instead, the operation is guaranteed by executing the following command and actually checking the operation.

  • python3 gfzs/views/not_found.py
  • python3 gfzs/views/paging.py
  • python3 gfzs/views/footer.py
  • python3 gfzs/views/header.py
  • python3 gfzs/views/search_result.py
  • python3 gfzs/utils/markup.py
  • python3 gfzs/utils/color.py
  • python3 gfzs/runtime/config.py
  • python3 gfzs/cmd/init.py
  • python3 gfzs/cmd/edit.py
  • python3 gfzs/cmd/demo.py
  • python3 gfzs/cmd/valid.py
  • python3 gfzs/controller.py
  • python3 gfzs/model.py
  • cat fixtures/rust.json | bin/gfzs -s 20 -l 0 -p ./tmp/gfzs.log
  • cat fixtures/rust.json | python3 -m gfzs -s 40 -l 0 -p ./tmp/gfzs.log
  • bin/gfzs -l 0 -p ./tmp/gfzs.log init
  • bin/gfzs -l 0 -p ./tmp/gfzs.log edit
  • bin/gfzs -l 0 -p ./tmp/gfzs.log demo
  • bin/gfzs -l 0 -p ./tmp/gfzs.log valid
  • black gfzs/**/*.py

@yukihirop yukihirop added this to the 0.2.3 milestone Feb 1, 2021
@yukihirop yukihirop self-assigned this Feb 1, 2021
@yukihirop yukihirop linked an issue Feb 1, 2021 that may be closed by this pull request
Modify Singleton Class #18
Closed
@yukihirop yukihirop force-pushed the issues18/modify_singleton_class branch from 52a712d to b29bcb7 Compare February 1, 2021 16:22
@yukihirop
Copy link
Owner Author

LGTM

@yukihirop yukihirop merged commit 14a0e6a into features/0.2.3 Feb 1, 2021
@yukihirop yukihirop deleted the issues18/modify_singleton_class branch February 1, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yukihirop yukihirop

Labels
None yet
Projects
None yet
Milestone
0.2.3
Development

Successfully merging this pull request may close these issues.

Modify Singleton Class
1 participant
@yukihirop