[#15872] docdb: show tserver uptime as "unknown" during leader failover gap #28430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r failover gap summary: When the master leader fails over, there’s a short window before the new leader receives heartbeats from tablet servers. During this gap, the master reports uptime=0 for alive tservers, which is misleading (the tserver has been up; the leader just hasn’t learned its uptime yet). If a tablet server is marked ALIVE but the reported uptime is 0, display the uptime as "unknown" instead of 0. This prevents falsely implying a restart during leader transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
When the master leader fails over, there’s a short window before the new leader receives heartbeats from tablet servers. During this gap, the master reports uptime=0 for alive tservers, which is misleading (the tserver has been up; the leader just hasn’t learned its uptime yet).
If a tablet server is marked ALIVE but the reported uptime is 0, display the uptime as "unknown" instead of 0. This prevents falsely implying a restart during leader transitions.