Skip to content

Conversation

ok-Mook
Copy link

@ok-Mook ok-Mook commented May 30, 2025

This PR addresses issue #27167.

  • Added an early exit check in TabletServiceAdminImpl::UpgradeYsql to handle the case when YSQL is not enabled.
  • Added a corresponding integration test in YsqlMajorUpgradeTest to verify correct behavior when YSQL is disabled.
  • Unable to fully verify locally due to macOS build environment conflicts, but submitting for alternative validation.

@CLAassistant
Copy link

CLAassistant commented May 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 30, 2025

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c75f01b
🔍 Latest deploy log https://app.netlify.com/projects/infallible-bardeen-164bc9/deploys/683a064a5960b0000888a39f
😎 Deploy Preview https://deploy-preview-27442--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ok-Mook ok-Mook changed the title Master [tserver] Add YSQL enabled check to UpgradeYsql and corresponding test (#27167) May 30, 2025
@iSignal
Copy link
Contributor

iSignal commented Aug 7, 2025

@ok-Mook : Thanks for raising this PR. Looks like this was recently addressed by @hari90 in a similar change but feel free to pick up any other interesting issues, for ex: #27168 that was opened by @hari90 recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants