Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend #12

Merged
merged 27 commits into from
Mar 6, 2025
Merged

Frontend #12

merged 27 commits into from
Mar 6, 2025

Conversation

cindytsai
Copy link
Collaborator

@cindytsai cindytsai commented Mar 3, 2025 •
edited
Loading

Frontend

  • Block the interrupt/restart/restart and run all buttons and notify user that they aren't supported by jupyter-libyt yet, instead of sending unwanted instructions to the kernel.
  • Block the kernel main menu interrupt/restart/restart and clear outputs of all cells and notify user that they aren't supported yet.

Known Bugs

It looks like semantic command extension point in JupyterLab aren't supporting re-defining restart kernel and run up to selected cells and restart kernel and run all cells.
So clicking them will still send restart (which we don't want, because libyt hasn't supported yet).

Notes

Due to the JupyterLab api:

  • Supports only JupyterLab >= 4.0.0
  • Drop support for python-3.7. (JupyterLab >= 4.0.0 doesn't support python-3.7)

Todos

  • Update readme
    • Change log
  • Bump version to 0.2.0
  • Make sure the package can be installed correctly.

cindytsai added 25 commits August 29, 2024 12:47
@cindytsai
Merge branch 'Pre-v0.1'
015348a
@cindytsai
Merge remote-tracking branch 'yt-project/main'
0491cbc
@cindytsai
Setup jupyter extension packages.
233889d
@cindytsai
pip install can now work.
1e39d9f
@cindytsai
Move setup.cfg to tox.ini pyproject.toml
06f8a06
@cindytsai
Make it append kernel info to jupyter kernelspec on install.
8235440
@cindytsai
Move setup.cfg config to tox.ini or pyproject.toml.
b487c7b
@cindytsai
Version 0.1.1 for testing.
c1f3ee7 
At some point, I think I have commit version 0.1.1 in pyproject.toml.
@cindytsai
Make sure frontend have effect in package.
9de74fd
@cindytsai
Add behavior to interrupt kernel button in toolbar. (Worked)
f4311ef
@cindytsai
Redefine the restart and restart-run-all commands in jupyter-libyt.
3ef7745 
And  make sure it only takes effects in libyt_kernel.
@cindytsai
Run jlpm prettier.
65db261
@cindytsai
Make it an array.
fc03ec8
@cindytsai
Update comments.
8e8286e
@cindytsai
Using semantic commands to change kernel menu behavior
308dc4e
@cindytsai
Use semantic command to change restart kernel behavior in menu.
a94b60d
@cindytsai
Make jupyter-libyt extension store under @yt-project folder.
19f39af
@cindytsai
Fix making jupyter-libyt to @yt-project/jupyter-libyt
8da49ec
@cindytsai
Probably should also change this.
c092cd2 
Comparing to another dummy module created using python package jupyter_libyt.
@cindytsai
Fix dep conflict.
ca22777
@cindytsai
Make sure it passes linting check.
994e856
@cindytsai
Remove unused dependencies.
bec9a06
@cindytsai
Add keyword.
4514a6c
@cindytsai
Build source and wheel.
8ae117d
@cindytsai
Run jlpm lint in workflow.
a56ec37
@cindytsai cindytsai mentioned this pull request Mar 3, 2025
Merged
@cindytsai cindytsai merged commit bfbf487 into yt-project:main Mar 6, 2025
10 checks passed
@cindytsai cindytsai deleted the Frontend branch March 6, 2025 02:14
@cindytsai cindytsai restored the Frontend branch March 6, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cindytsai