[ie/taptap] Add new extractor for taptap.cn #9776
Conversation
yt_dlp/extractor/taptap.py
Outdated
| webpage = self._download_webpage(url, list_id) | ||
| nuxt_data = self._deserialize_nuxt_data(self._search_json( | ||
| r'<script[^>]+\bid=["\']__NUXT_DATA__["\'][^>]*>', webpage, | ||
| 'nuxt data', list_id, contains_pattern=r'\[(?s:.+)\]'))[1] | ||
| x_ua = traverse_obj(nuxt_data, ( | ||
| 'state', '$sbff', ..., {lambda x: parse_qs(x)['X-UA']}, ...), get_all=False) |
There was a problem hiding this comment.
I think instead of parsing the hydration data it would be better to call the API directly
https://www.taptap.cn/webapiv2/app/v4/detail
https://www.taptap.cn/webapiv2/moment/v3/detail
I haven't looked too much in to the structure of the returned data, but it could make sense to put the _extract_video in to a base class and have separate extractors for moment/app content.
yt_dlp/extractor/taptap.py
Outdated
| if '.m3u8' in video['url']: | ||
| video['formats'] = self._extract_m3u8_formats(video.pop('url'), video_id) |
There was a problem hiding this comment.
I would extract both the AVC and HEVC formats every time. I think that additional request is worth it, or is there any reason like excessive rate limiting not to do this?
yt_dlp/extractor/taptap.py
Outdated
|
|
||
|
|
||
| class TapTapIE(InfoExtractor): | ||
| _VALID_URL = r'https?://www\.taptap\.cn/(?P<section>moment|app)/(?P<id>\d+)' |
There was a problem hiding this comment.
Could we also support taptap.io? The site structure is very similar. I think this should be doable with only minimal adjustments.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Add support for video extraction from
taptap.cnposts and game topic pagesFixes #9643
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?