-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/orf:on] Improve extraction #9677
Conversation
68ae87a
to
e3192e8
Compare
use the linked subtitles in the v4.3 api
some urls are without slug also some video-Id's are shorter that 8 digits and could probably be bigger than 8
e3192e8
to
f51d16b
Compare
some videos formats were not reported as DRM protected fixes: yt-dlp#9652
new test file has no kill_date, so I hope it will be online for longer old one will be not available after "2024-08-12T21:05:00+02:00"
as display_id is optional it does not make sense to keep it
f51d16b
to
c30f9fc
Compare
Please do not force push. All commits will be squashed upon merge, and it makes reviewing harder. |
thanks for the Feedback, try to add the changes and rerun the tests. Force Push, |
Thanks again for the good feedback. I'm not sure about the subtitles as I not wanted to break Otherwise should be good now. |
interrate over all subtitles and sort that `vtt` is default, so `--embed-subs` is working out of the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments from me
as `vtt_url` is the last in the list, it will get priority
Co-authored-by: sepro <[email protected]>
Thanks again for the nice Review! I got today motivated to publish my documentation for the API Feel free to us it |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
example for 7 digits: https://on.orf.at/video/3229173
the new test data has
killdate: None
as attribute, so this should be more stable for the futuresadly I did't found any video with age restriction and
right: "worldwide"
only with restriction to Austria and/or with akilldate
< 2025, IMHO not worth to add as will create future problemTemplate
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Open Questions:
'xml', 'srt', 'sami', 'ttml', 'stl'
that are available so I comment them outdisplay_id
be remove?! as it is not included with all urls fromon.orf.at
As this is my first PR to
yt-dlp
I hope I didn't oversaw anything from the good written guidelines.If so feel free to point that out.