Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use data-allow-mismatch to suppress hydration mismatch warnings #13122

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Sep 18, 2024

#12719 (comment)

Note that this PR only ignores the warnings. we will thoroughly fix the issue when the time is right.

@inottn inottn marked this pull request as draft September 19, 2024 03:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (b378a3c) to head (b7d331c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13122   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         257      257           
  Lines        6999     6999           
  Branches     1730     1730           
=======================================
  Hits         6568     6568           
  Misses        375      375           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inottn inottn marked this pull request as ready for review September 19, 2024 05:41
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻

@chenjiahan chenjiahan merged commit a08f4ff into youzan:main Sep 22, 2024
3 checks passed
@inottn inottn deleted the data-allow-mismatch branch October 14, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants